Skip to content

Feature/citation count dropdown#15216

Draft
aliyasirnac wants to merge 2 commits intoJabRef:mainfrom
aliyasirnac:feature/citation-count-dropdown
Draft

Feature/citation count dropdown#15216
aliyasirnac wants to merge 2 commits intoJabRef:mainfrom
aliyasirnac:feature/citation-count-dropdown

Conversation

@aliyasirnac
Copy link

@aliyasirnac aliyasirnac commented Feb 26, 2026

Related issues and pull requests

Closes #15134

PR Description

This PR adds a fetcher selection dropdown to the CitationCountEditor in the General tab, allowing users to choose which source (Semantic Scholar, OpenAlex, OpenCitations, or scite.ai) is used to fetch the citation count for an entry. A new CitationCountFetcherType enum was introduced to separate citation count fetching from citation relation fetching, and SciteAiFetcher was updated to implement CitationCountFetcher. The selected fetcher is stored as a preference and kept in sync with SearchCitationsRelationsService.

This is a draft PR — next steps:

  • Add unit tests for CitationCountFetcherType and updated SciteAiFetcher
  • Update CHANGELOG.md
  • Add screenshot showing the dropdown in the General tab

Steps to test

  1. Open JabRef and add an entry with a DOI (e.g. 10.1145/1028174.971312)
  2. Navigate to the General tab in the entry editor
  3. Find the Citationcount field — a dropdown should appear next to it
  4. Select a different fetcher from the dropdown (Semantic Scholar, OpenAlex, etc.)
  5. Click the refresh button — citation count should update from the selected source

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [.] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@github-actions
Copy link
Contributor

Hey @aliyasirnac! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing. We also use Qodo for review assistance. It will update your pull request description with a review help and offer suggestions to improve the pull request.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. You can read about the whole pull request process in our contribution guide.

Please ensure that your pull request is in line with our AI Usage Policy and make necessary disclosures.

@github-actions github-actions bot added first contrib good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 26, 2026
@jabref-machine
Copy link
Collaborator

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of - [x] (done), - [ ] (yet to be done) or - [/] (not applicable). Please adhere to our pull request template.

@jabref-machine
Copy link
Collaborator

JUnit tests of jabkit are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Source Code Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first contrib good first issue An issue intended for project-newcomers. Varies in difficulty. status: changes-required Pull requests that are not yet complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add citation count selection to entry editor

2 participants