Update the handling of arXiv/DOI #12349
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
| @@ -41,7 +41,7 @@ void setup() { | |||
| @Test | |||
| void badFilenameCharWillBeReplacedByUnderscore(@TempDir Path tempDir) throws Exception { | |||
|
|
|||
| Path invalidFile = tempDir.resolve("?invalid.pdf"); | |||
| @@ -25,9 +25,16 @@ public List<IntegrityMessage> check(BibEntry entry) { | |||
| List<IntegrityMessage> messages = new ArrayList<>(); | |||
| for (Field field : fields) { | |||
| Optional<String> value = entry.getFieldLatexFree(field); | |||
|
|
|||
| // Debugging Output | |||
There was a problem hiding this comment.
if you want to have debug output just use LOGGER.debug
There was a problem hiding this comment.
@laky241 hey, welcome to open source!
Before making a pull request, you can ask to be assigned on the issue.
Please take a look at the contributing guidelines and howtos on setting up a local workspace.
We do not encourage newcomers to be heavily reliant on AI (as it takes away the learning opportunity from the contributor and other people who may have been interested), but it is understandable considering you are new to here, so appreciate the effort!
I am closing this PR for now, you can come back anytime to work again on another issue once you have everything set up.
fixes #12292
We improved the InspireHEP API so that the cite key is consistent, no matter how you search. Before, if you searched using an arXiv number or DOI, the cite key would show up as a long DOI URL, which wasn't ideal. Now, we’ve added a "texkeys" field that returns the proper cite key across all search types, making it easier to use.
Added a "texkeys" field to the API response for searches using unique identifiers like arXiv numbers.
This ensures that the cite key is consistent, whether you're searching normally or by arXiv number/DOI.
Updated the API to include the correct cite key for all search methods, improving usability.