Fix content not correctly parsed at pdf content importer #12338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. is far away should compare with the last one in font size, not the former text 2. fix the abs value issue. 3. fix the Ygap calculate issue.
|
@InAnYan You are currently more into the pdf parsing, can you take a look? |
Siedlerchr
changed the title
Siedlerchr
previously approved these changes
Jan 3, 2025
|
Tests are inlcuded so from my point of view this is fine |
|
As we released 6.0 alpha, can you please add a changelog entry like? |
Siedlerchr
added
the
status: ready-for-review
Siedlerchr
approved these changes
Jan 4, 2025
sry I was busy last week didn't do it, next time I'll add changelog if necessary. |
Siedlerchr
added a commit
that referenced
this pull request
Jan 8, 2025
* upstream/main: Update abbrv.jabref.org (#12365) Bump buildres/abbrv.jabref.org from `78e1b08` to `c202741` (#12363) Bump org.beryx.jlink from 3.1.0-rc-1 to 3.1.1 (#12362) Bump tech.units:indriya from 2.2.1 to 2.2.2 (#12361) Bump com.dlsc.gemsfx:gemsfx from 2.80.0 to 2.81.0 (#12360) Bump org.mariadb.jdbc:mariadb-java-client from 2.7.9 to 2.7.12 (#12359) Bump org.mockito:mockito-core from 5.14.2 to 5.15.2 (#12358) Fix content not correctly parsed at pdf content importer (#12338) Bump de.undercouch:citeproc-java from 3.1.0 to 3.2.0 (#12347) Bump org.openrewrite.rewrite from 6.29.0 to 6.29.2 (#12345) Improve utf8 detection (#12342) Bump org.fxmisc.richtext:richtextfx from 0.11.3 to 0.11.4 (#12346) Bump ai.djl:bom from 0.30.0 to 0.31.1 (#12344) Bump com.puppycrawl.tools:checkstyle from 10.21.0 to 10.21.1 (#12343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12278
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)