Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just Delete link from entry if the file is no longer accesible on disk #12324

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Just Delete link from entry if the file is no longer accesible on disk #12324

merged 2 commits into from
Dec 23, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 22, 2024 •
edited
Loading

Fixes #9731

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 22, 2024
subhramit
subhramit reviewed Dec 22, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Siedlerchr @subhramit
Update CHANGELOG.md
1e3e3f7 
Co-authored-by: Subhramit Basu Bhowmick <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr enabled auto-merge December 22, 2024 19:22
@Siedlerchr Siedlerchr added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit c8acffe Dec 23, 2024
26 of 27 checks passed
@Siedlerchr Siedlerchr deleted the deleteNOnExistingFileFromEntry branch December 23, 2024 15:24
@koppor koppor mentioned this pull request Dec 23, 2024
Merged
7 tasks
ar-rana pushed a commit to ar-rana/jabref that referenced this pull request Dec 26, 2024
@Siedlerchr @subhramit @ar-rana
Just Delete link from entry if the file is no longer accesible on disk (
3a459bf 
JabRef#12324)

* Just Delete link from entry if the file is no longer accesible on disk

Fixes JabRef#9731

* Update CHANGELOG.md

Co-authored-by: Subhramit Basu Bhowmick <[email protected]>

---------

Co-authored-by: Subhramit Basu Bhowmick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhramit subhramit subhramit left review comments

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with adding/deleting linked files
3 participants
@Siedlerchr @calixtus @subhramit