[OO] Major performance improvements & fixes#12221
Merged
Siedlerchr merged 4 commits intoJabRef:mainfrom Nov 24, 2024
Merged
Conversation
Contributor
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
Member
Author
|
Feels weird to not pass my own tests 😅 |
calixtus
previously approved these changes
Nov 23, 2024
Member
|
Looks good. Thanks for keeping up the work on your code. |
Siedlerchr
approved these changes
Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSL4LibreOffice - Performance improvements and fixes
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/697
Reduces the number of UNO API calls -
a) The
OOTextIntoOO#write()method by default shifts the cursor to the end of the text after operations are done, so callingcursor.collapseToEnd()everywhere is needless.b) Explicit deletion of extra newlines/paragraph breaks using
cursor.setString()is no longer needed in case of numeric styles - RegEx intransformHTMLis now adapted to handle it before it is inserted into the document, which is way faster.Changes newlines in bibliography to paragraph breaks, improving performance of documents with a large number of bibliographic entries drastically, as per information from https://bugs.documentfoundation.org/show_bug.cgi?id=163984


Old:
New:
Fixes extra newlines before each numeric bibliographic entry, which also used to cause one to be placed after the title (see comparison above)
Some miscellaneous documentation enhancements
Credits to @ThiloteE for investigating and the @LibreOffice community for prompt support!
Mandatory checks
Change in[Changes in unreleased]CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)Tests created for changes (if applicable)