Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content not correctly parsed at pdf content importer #12338

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

leaf-soba
Copy link
Contributor

@leaf-soba leaf-soba commented Dec 27, 2024

Closes #12278

  1. is far away should compare with the last one in font size, not the former text
  2. fix the abs value issue.
  3. fix the Ygap calculate issue.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

1. is far away should compare with the last one in font size, not the former text
2. fix the abs value issue.
3. fix the Ygap calculate issue.
@Siedlerchr
Copy link
Member

@InAnYan You are currently more into the pdf parsing, can you take a look?

@Siedlerchr Siedlerchr changed the title Fix the isFarAway issue Fix content not correctly parsed at pdf content importer Jan 1, 2025
Siedlerchr
Siedlerchr previously approved these changes Jan 3, 2025
@Siedlerchr
Copy link
Member

Tests are inlcuded so from my point of view this is fine

@Siedlerchr
Copy link
Member

Siedlerchr commented Jan 3, 2025

As we released 6.0 alpha, can you please add a changelog entry like?
We improved the offline pdf content parsing

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 3, 2025
@Siedlerchr Siedlerchr enabled auto-merge January 4, 2025 13:11
@Siedlerchr Siedlerchr added this pull request to the merge queue Jan 4, 2025
Merged via the queue into JabRef:main with commit 1e837cd Jan 4, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content of "opium.pdf" not correctly parsed
2 participants