Add agent endpoints #1450
Add agent endpoints #1450
Conversation
|
Sorry, I only added the endpoints that I need to use. |
| brokerId.ValidateNotNull(nameof(brokerId)); | ||
|
|
||
| var parameters = new ParameterCollection(); | ||
| parameters.AddOptional("brokerId", brokerId.ToString(CultureInfo.InvariantCulture)); |
There was a problem hiding this comment.
This should just be parameters.Add("brokerId", brokerId);
It's not optional and it's already a string
|
|
||
| var parameters = new ParameterCollection(); | ||
| parameters.AddOptional("brokerId", brokerId.ToString(CultureInfo.InvariantCulture)); | ||
| parameters.AddOptional("type", (int)IfNewUserMarginedFuturesType.Coin_margined_Futures); |
There was a problem hiding this comment.
Use parameters.AddEnum("type", IfNewUserMarginedFuturesType.Coin_margined_Futures); instead
Binance.Net/Clients/CoinFuturesApi/BinanceRestClientCoinFuturesApiAgent.cs
Show resolved
Hide resolved
|
|
||
| #region If New User | ||
|
|
||
| public async Task<WebCallResult<BinanceIfNewUser>> IfNewUser(string apiAgentCode, int? receiveWindow = null, CancellationToken ct = default) |
| /// Processing | ||
| /// </summary> | ||
| [Map("1")] | ||
| USDT_margined_Futures = 1, |
There was a problem hiding this comment.
Use CamelCasing please, so UsdtMarginedFutures
| namespace Binance.Net.Interfaces.Clients.UsdFuturesApi | ||
| { | ||
| /// <summary> | ||
| /// Binance USD-M futures account endpoints, query user data. |
| namespace Binance.Net.Interfaces.Clients.CoinFuturesApi | ||
| { | ||
| /// <summary> | ||
| /// Binance Coin futures account endpoints, query user data. |
| /// If new user | ||
| /// </summary> | ||
| [JsonPropertyName("ifNewUser")] | ||
| public bool ifNewUser { get; set; } = false; |
There was a problem hiding this comment.
IfNewUser, also default values not needed for bool values as the default is already false
| /// If new user | ||
| /// </summary> | ||
| [JsonPropertyName("ifNewUser")] | ||
| public bool ifNewUser { get; set; } = false; |
|
Please have a look at the comments |
|
I made some modifications, but "rate limiter" doesn't seem to be in the documentation, except for weight. |
| brokerId.ValidateNotNull(nameof(brokerId)); | ||
|
|
||
| var parameters = new ParameterCollection(); | ||
| parameters.AddOptional("brokerId", brokerId); |
There was a problem hiding this comment.
You removed the ToString, but it still should be parameters.Add instead of parameters.AddOptional
| brokerId.ValidateNotNull(nameof(brokerId)); | ||
|
|
||
| var parameters = new ParameterCollection(); | ||
| parameters.AddOptional("brokerId", brokerId.ToString(CultureInfo.InvariantCulture)); |
There was a problem hiding this comment.
Same, you also still have the ToString here
I see, it's not really clear what the limits are so I guess this is good enough. 2 more small comments. |
|
Done! |
No description provided.