Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom message in failure #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eruffaldi
Copy link

@eruffaldi eruffaldi commented Nov 25, 2018

TestFailure/TestError should report the custom error text message as specified in the check.

image

Before Patch:

<testsuite name="TestSuite">
<testcase classname="test1case" name="testExample1" time="0.047057628631592">
  <failure message="Test Failure" type="testFailure">TEST_FAILURE: 3.000000 != 4.000000</failure>
</testcase>
</testsuite>

After Patch:

<testsuite name="TestSuite">
<testcase classname="test1case" name="testExample1" time="0.047057628631592">
  <failure message="MESSAGE" type="testFailure">TEST_FAILURE: 3.000000 != 4.000000</failure>
</testcase>
</testsuite>

Where MESSAGE is the one passed to the pass VI:

image

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Emanuele Ruffaldi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants