Skip to content

[release/2.0] Fix MET segfaults (fixup_rpath --> environment modification) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
climbfuji merged 1 commit into from
Dec 11, 2025
Merged

[release/2.0] Fix MET segfaults (fixup_rpath --> environment modification) #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions repos/spack_repo/builtin/packages/met/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,21 @@ def configure_args(self):

return args

@run_after("install", when="platform=linux")
def fixup_rpaths(self):
# set rpaths of binaries Python's lib directory
rpaths = self.spec["python"].libs.directories
# Adding the Python rpaths to the MET binaries randomly causes
# segmentation faults for different versions of MET and for
# different compilers - set LD_LIBRARY_PATH instead below
# (https://github.com/JCSDA/spack-stack/issues/1839)
#@run_after("install", when="+python platform=linux")
#def fixup_rpaths(self):
# # set rpaths of binaries Python's lib directory
# rpaths = self.spec["python"].libs.directories
#
# for binary in find(self.prefix.bin, "*"):
# patchelf = Executable("patchelf")
# patchelf("--add-rpath", ":".join(rpaths), binary)

def setup_run_environment(self, env: EnvironmentModifications) -> None:
if self.spec.satisfies("+python"):
for libpath in self.spec["python"].libs.directories:
env.append_path("LD_LIBRARY_PATH", libpath)

for binary in find(self.prefix.bin, "*"):
patchelf = Executable("patchelf")
patchelf("--add-rpath", ":".join(rpaths), binary)

# def setup_run_environment(self, env: EnvironmentModifications) -> None:
# env.set('MET_BASE', self.prefix)