UKMO RH Sprint: Updates needed for ufo changes from fraction to percentage rh - #579
Open
mikecooke77 wants to merge 24 commits into
Open
UKMO RH Sprint: Updates needed for ufo changes from fraction to percentage rh#579mikecooke77 wants to merge 24 commits into
mikecooke77 wants to merge 24 commits into
Conversation
Co-authored-by: Reuben W. Nixon-Hill <ReubenHill@users.noreply.github.com>
…ernal/ufo-data into feature/sprint-ukmo-rh
…ofile-average UKMO RH Sprint: Change RH GeoVals to fractions in test file for ProfileAverage
…rtinterp-scale-pmissing Test file for scaling of background error vertical interpolation with missing values
mikecooke77
requested review from
ReubenHill,
cmgas,
Copilot,
ctgh and
rajichidamb
June 30, 2026 10:23
There was a problem hiding this comment.
Pull request overview
This PR updates the ufo-data test input datasets (Git LFS-tracked NetCDF/NetCDF4 files) to support the UKMO RH unit change (percentage ↔ fraction) and adds additional sondes datasets needed for new UFO handling of RH units on the observation side.
Changes:
- Updated multiple existing
testinput_tier_1/*geovals*NetCDF/NetCDF4 datasets (Git LFS pointers changed to new object IDs). - Added three new sondes background-error/obsdiag-scaled datasets as Git LFS-tracked NetCDF4 files.
- Confirmed repository-wide LFS tracking covers
*.ncand*.nc4via.gitattributes.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testinput_tier_1/surface_geovals_namemap_20210521T1200Z.nc4 | Updated LFS object for surface geovals namemap test input. |
| testinput_tier_1/sondes_background_error_vert_interp_air_pressure_obsdiag_scaled_obsspace_missing_2018041500_s.nc4 | New LFS-tracked sondes dataset (missing obsspace variant) for updated testing. |
| testinput_tier_1/sondes_background_error_vert_interp_air_pressure_obsdiag_scaled_obsspace_2018041500_s.nc4 | New LFS-tracked sondes dataset (obsspace) for updated testing. |
| testinput_tier_1/sondes_background_error_vert_interp_air_pressure_obsdiag_scaled_geovals_2018041500_s.nc4 | New LFS-tracked sondes dataset (geovals) for updated testing. |
| testinput_tier_1/satwind_geoval_small_20201001T0600Z.nc4 | Updated LFS object for satwind small geovals test input. |
| testinput_tier_1/satwind_geoval_20201001T0600Z.nc4 | Updated LFS object for satwind geovals test input. |
| testinput_tier_1/pace_radiance_geovals_2019032112.nc | Updated LFS object for PACE radiance geovals test input. |
| testinput_tier_1/mtgirs_geovals_202106241200_5locs.nc4 | Updated LFS object for MTGIRS geovals test input. |
| testinput_tier_1/met_office_rh_corr_gv.nc4 | Updated LFS object for Met Office RH correction geovals test input. |
| testinput_tier_1/met_office_profile_cxinterpolation_geovals.nc4 | Updated LFS object and size for Met Office profile CX interpolation geovals test input. |
| testinput_tier_1/met_office_conventional_profile_processing_average_geovals.nc4 | Updated LFS object for Met Office conventional profile processing average geovals test input. |
| testinput_tier_1/met_office_conventional_profile_processing_average_geovals_extended.nc4 | Updated LFS object for extended Met Office conventional profile processing average geovals test input. |
| testinput_tier_1/gnssro_geoval_20210701T1200Z_profile.nc4 | Updated LFS object for GNSSRO profile geovals test input. |
| testinput_tier_1/geovals_ssmis_onedvar_20210701T1200Z.nc4 | Updated LFS object for SSMIS onedvar geovals test input. |
| testinput_tier_1/geovals_gmihigh_20210701T1200Z_out_0000_m.nc4 | Updated LFS object for GMI high geovals test input. |
| testinput_tier_1/geovals_atovs_transmittance_20210701T1200Z.nc4 | Updated LFS object for ATOVS transmittance geovals test input. |
| testinput_tier_1/geovals_atovs_lwpguess_20210701T1200Z.nc4 | Updated LFS object for ATOVS LWP guess geovals test input. |
| testinput_tier_1/geovals_atovs_20210115T1200Z_seaice.nc4 | Updated LFS object for ATOVS seaice geovals test input. |
| testinput_tier_1/geovals_atovs_20210115T1200Z_rttov_scatt.nc4 | Updated LFS object for ATOVS RTTOV scatt geovals test input. |
| testinput_tier_1/geovals_atovs_20210115T1200Z_multiplatform.nc4 | Updated LFS object for ATOVS multiplatform geovals test input. |
| testinput_tier_1/geovals_atms_20200401T0000Z_allsurfacetypes.nc4 | Updated LFS object for ATMS all-surface-types geovals test input. |
| testinput_tier_1/cloudtoppressure_testdata_geovals.nc4 | Updated LFS object for cloud top pressure geovals test input. |
| testinput_tier_1/atms_geovals_20200401T0000Z_10locs.nc4 | Updated LFS object for ATMS 10-locs geovals test input. |
| testinput_tier_1/amsr2_geovals_20191230T0000Z_100subset.nc4 | Updated LFS object for AMSR2 subset geovals test input. |
| testinput_tier_1/airs_aqua_20210701T1200Z_geovals_obfn_setsurface.nc4 | Updated LFS object for AIRS Aqua geovals (obfn setsurface) test input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rajichidamb
approved these changes
Jul 2, 2026
ReubenHill
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates files that need changing for the switch of the model data from percentage to fraction. This also updates a few files because of additional testing added for new UFO functionality to deal with fraction or percentage RH on the observation side.
Issue(s) addressed
None in this repo.
Dependencies
To be merged with the following friends:
build-group=https://github.com/JCSDA-internal/vader/pull/372
build-group=JCSDA-internal/jedi-model-data#16
build-group=https://github.com/JCSDA-internal/ufo/pull/4221
UKMO specific
build-group=https://github.com/MetOffice/ops-um-jedi/pull/280
build-group=MetOffice/opsinputs#289
lfric-jedi=https://github.com/MetOffice/lfric-jedi/pull/1301
jjtests=https://github.com/MetOffice/lfric-jedi/pull/1301
Impact
This merge needs coordinating across several repositories.
Checklist