Skip to content

Fix: preserve independent validation contracts - #218

Merged
ivory-code merged 1 commit into
mainfrom
fix/preserve-independent-validation-contracts
Aug 25, 2026
Merged

Fix: preserve independent validation contracts#218
ivory-code merged 1 commit into
mainfrom
fix/preserve-independent-validation-contracts

Conversation

@ivory-code

Copy link
Copy Markdown
Contributor

Summary

  • Keep independent behavior commits separate even when they edit one shared analyzer file.
  • Prevent partial identifier matches from turning unrelated symbols into routing evidence.
  • Preserve every changed test and benchmark contract while keeping qa run bounded to one selected command.
  • Align the English and Korean README, agent schema, command reference, architecture notes, and roadmap with the actual execution boundary.

Behavioral Contract

QAMap must not merge unrelated commits solely because they share a central file, and identifiers such as requireDirectory must not become redirect or navigation evidence. When one change modifies several independent validation contracts, QAMap selects one command for qa run, reports the remaining commands through route.additionalCommands, and keeps every unexecuted command marked not run.

Evidence

  • Minimized negative control: shared analyzer files do not merge independent feature commits
  • Routing boundary and positive control: routing evidence respects identifier boundaries without losing real redirect symbols
  • Multi-contract fixture: qa preserves every changed test and benchmark validation contract

Checks

Check only what applies. Mark the rest N/A in Review Notes.

  • Focused regression test
  • pnpm test
  • pnpm bench:ci for inference, routing, trace, or output
  • pnpm bench:execution for E2E compiler or execution fixtures
  • pnpm scan for scanner, security, or repository policy
  • pnpm plugin:check and pnpm plugin:smoke for plugin changes
  • Documentation links and commands verified

Public OSS Check

  • No private repository, source, path, customer data, credential, or internal smoke output is included.
  • Shared inference has unrelated positive and negative coverage, or this is not applicable.
  • User-facing commands and claims match actual behavior.

Review Notes

The agent schema change is additive: route.additionalCommands is optional and the readiness enum gains additional-commands-required. qa run still executes exactly one repository-owned command. The full suite passed with 412 tests, 35 static benchmark contracts, 3 execution benchmark contracts, plugin checks, package smoke validation, and coverage above the configured 80% thresholds. This PR does not bump or publish a version.

@ivory-code ivory-code added type: fix Bug fix or corrective follow-up area: qa-planning PR-aware QA planning, coverage, evidence, and fixture readiness area: agent-readiness Agent instructions, readiness, and workspace hygiene area: validation Validation commands, readiness eval, and verify workflows labels Aug 25, 2026
@ivory-code ivory-code self-assigned this Aug 25, 2026
@ivory-code
ivory-code merged commit c57a62e into main Aug 25, 2026
2 checks passed
@ivory-code
ivory-code deleted the fix/preserve-independent-validation-contracts branch August 25, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: agent-readiness Agent instructions, readiness, and workspace hygiene area: qa-planning PR-aware QA planning, coverage, evidence, and fixture readiness area: validation Validation commands, readiness eval, and verify workflows type: fix Bug fix or corrective follow-up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant