Fix: preserve independent validation contracts - #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qa runbounded to one selected command.Behavioral Contract
QAMap must not merge unrelated commits solely because they share a central file, and identifiers such as
requireDirectorymust not become redirect or navigation evidence. When one change modifies several independent validation contracts, QAMap selects one command forqa run, reports the remaining commands throughroute.additionalCommands, and keeps every unexecuted command markednot run.Evidence
shared analyzer files do not merge independent feature commitsrouting evidence respects identifier boundaries without losing real redirect symbolsqa preserves every changed test and benchmark validation contractChecks
Check only what applies. Mark the rest
N/Ain Review Notes.pnpm testpnpm bench:cifor inference, routing, trace, or outputpnpm bench:executionfor E2E compiler or execution fixturespnpm scanfor scanner, security, or repository policypnpm plugin:checkandpnpm plugin:smokefor plugin changesPublic OSS Check
Review Notes
The agent schema change is additive:
route.additionalCommandsis optional and the readiness enum gainsadditional-commands-required.qa runstill executes exactly one repository-owned command. The full suite passed with 412 tests, 35 static benchmark contracts, 3 execution benchmark contracts, plugin checks, package smoke validation, and coverage above the configured 80% thresholds. This PR does not bump or publish a version.