forked from firecracker-microvm/firecracker
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commit was created by running `mdformat .` in the repository root. Signed-off-by: Patrick Roy <[email protected]>
- Loading branch information
Showing
59 changed files
with
3,120 additions
and
3,161 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
# Code of Conduct | ||
|
||
This project has adopted the | ||
[Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). | ||
For more information see the | ||
[Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct). For | ||
more information see the | ||
[Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact | ||
[[email protected]](mailto:[email protected]) | ||
with any additional questions or comments. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,9 +33,9 @@ you want to merge your changes to Firecracker: | |
1. Add two reviewers to your pull request (a maintainer will do that for you if | ||
you're new). Work with your reviewers to address any comments and obtain a | ||
minimum of 2 approvals, at least one of which must be provided by | ||
[a maintainer](MAINTAINERS.md). | ||
To update your pull request amend existing commits whenever applicable and | ||
then push the new changes to your pull request branch. | ||
[a maintainer](MAINTAINERS.md). To update your pull request amend existing | ||
commits whenever applicable and then push the new changes to your pull | ||
request branch. | ||
1. Once the pull request is approved, one of the maintainers will merge it. | ||
|
||
## Request for Comments | ||
|
@@ -68,14 +68,20 @@ rusty-hook init | |
Your contribution needs to meet the following standards: | ||
|
||
- Separate each **logical change** into its own commit. | ||
|
||
- Each commit must pass all unit & code style tests, and the full pull request | ||
must pass all integration tests. See [tests/README.md](tests/README.md) for | ||
information on how to run tests. | ||
|
||
- Unit test coverage must _increase_ the overall project code coverage. | ||
|
||
- Include integration tests for any new functionality in your pull request. | ||
|
||
- Document all your public functions. | ||
|
||
- Add a descriptive message for each commit. Follow | ||
[commit message best practices](https://github.com/erlang/otp/wiki/writing-good-commit-messages). | ||
|
||
- A good commit message may look like | ||
|
||
``` | ||
|
@@ -87,19 +93,19 @@ Your contribution needs to meet the following standards: | |
Co-authored-by: <B full name> <B email> | ||
``` | ||
|
||
- **Usage of `unsafe` is heavily discouraged**. If `unsafe` is required, | ||
it should be accompanied by a comment detailing its... | ||
- **Usage of `unsafe` is heavily discouraged**. If `unsafe` is required, it | ||
should be accompanied by a comment detailing its... | ||
|
||
- Justification, potentially including quantifiable reasons why safe | ||
alternatives were not used (e.g. via a benchmark showing a valuable[^1] | ||
performance improvements). | ||
- Safety, as per [`clippy::undocumented_unsafe_blocks`](https://rust-lang.github.io/rust-clippy/master/#undocumented_unsafe_blocks). | ||
This comment must list all invariants of the called function, and | ||
explain why there are upheld. If relevant, it must also prove that | ||
- Safety, as per | ||
[`clippy::undocumented_unsafe_blocks`](https://rust-lang.github.io/rust-clippy/master/#undocumented_unsafe_blocks). | ||
This comment must list all invariants of the called function, and explain | ||
why there are upheld. If relevant, it must also prove that | ||
[undefined behavior](https://doc.rust-lang.org/reference/behavior-considered-undefined.html) | ||
is not possible. | ||
|
||
[^1]: Performance improvements in non-hot paths are unlikely to be considered valuable. | ||
|
||
E.g. | ||
|
||
```rust | ||
|
@@ -113,24 +119,26 @@ Your contribution needs to meet the following standards: | |
} | ||
``` | ||
|
||
- Document your pull requests. Include the reasoning behind each change, and | ||
the testing done. | ||
- Document your pull requests. Include the reasoning behind each change, and the | ||
testing done. | ||
|
||
- Acknowledge Firecracker's [Apache 2.0 license](LICENSE) and certify that no | ||
part of your contribution contravenes this license by signing off on all your | ||
commits with `git -s`. Ensure that every file in your pull request has a | ||
header referring to the repository license file. | ||
|
||
## Developer Certificate of Origin | ||
|
||
Firecracker is an open source product released under the [Apache 2.0 license](LICENSE). | ||
Firecracker is an open source product released under the | ||
[Apache 2.0 license](LICENSE). | ||
|
||
We respect intellectual property rights of others and we want to make sure all | ||
incoming contributions are correctly attributed and licensed. | ||
A Developer Certificate of Origin (DCO) is a lightweight mechanism to do that. | ||
incoming contributions are correctly attributed and licensed. A Developer | ||
Certificate of Origin (DCO) is a lightweight mechanism to do that. | ||
|
||
The DCO is a declaration attached to every contribution made by every | ||
developer. In the commit message of the contribution, the developer simply adds | ||
a `Signed-off-by` statement and thereby agrees to the DCO, which you can find | ||
The DCO is a declaration attached to every contribution made by every developer. | ||
In the commit message of the contribution, the developer simply adds a | ||
`Signed-off-by` statement and thereby agrees to the DCO, which you can find | ||
below or at DeveloperCertificate.org (<http://developercertificate.org/>). | ||
|
||
``` | ||
|
@@ -167,16 +175,19 @@ Certificate of Origin. DCO checks are enabled via <https://github.com/apps/dco>, | |
and your PR will fail CI without it. | ||
|
||
Additionally, we kindly ask you to use your real name. We do not accept | ||
anonymous contributors, nor those utilizing pseudonyms. | ||
Each commit must include a DCO which looks like this: | ||
anonymous contributors, nor those utilizing pseudonyms. Each commit must include | ||
a DCO which looks like this: | ||
|
||
``` | ||
Signed-off-by: Jane Smith <[email protected]> | ||
``` | ||
|
||
You may type this line on your own when writing your commit messages. | ||
However, if your `user.name` and `user.email` are set in your git config, | ||
you can use `-s` or `--signoff` to add the `Signed-off-by` line to the end of | ||
the commit message automatically. | ||
You may type this line on your own when writing your commit messages. However, | ||
if your `user.name` and `user.email` are set in your git config, you can use | ||
`-s` or `--signoff` to add the `Signed-off-by` line to the end of the commit | ||
message automatically. | ||
|
||
Forgot to add DCO to a commit? Amend it with `git commit --amend -s`. | ||
|
||
[^1]: Performance improvements in non-hot paths are unlikely to be considered | ||
valuable. |
Oops, something went wrong.