Update Nvector.cpp #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for operator|| doesn't work if the second vector contains a zero.
IvanFilipov
requested changes
Apr 7, 2023
| if (abs(coeff - curCoeff) > eps) | ||
| for (size_t i = 0; i < size; i++) | ||
| { | ||
| if (lhs[i] * rhs[i + 1] != lhs[i + 1] * rhs[i]) |
There was a problem hiding this comment.
Nice catch!
Yet, the proposed fix won't compile.
Perhaps we need to change the names "lhs" and "rhs" to "this.data" and "other.data"
accordingly.
Please, be aware that this repository is deprecated.
A lot of effort shall be put in, in order to make it reliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for operator|| doesn't work if the second vector contains a zero.
Fixed the algorithm to handle this cases.