Change parameters of update and delete methods #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I bought the book “Real-World Software Development” in Korea and I’m enjoying reading it.
I’ve read up to Chapter 2, and I found something unusual, so I submitted a PR.
In Example 2-9 of Chapter 2, the update() method seems a bit different from a typical update method.
I think it would be better if the update() method was designed to receive a
BankTransaction
domain as a parameter, which contains the target id and the content to be modified, and the delete() method was designed to receive only the id of the target to be deleted as a parameter. So, I made those modifications.Thank you. 👍