Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameters of update and delete methods #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fp024
Copy link

@fp024 fp024 commented Jun 19, 2024

Hello,

I bought the book “Real-World Software Development” in Korea and I’m enjoying reading it.

I’ve read up to Chapter 2, and I found something unusual, so I submitted a PR.

In Example 2-9 of Chapter 2, the update() method seems a bit different from a typical update method.

I think it would be better if the update() method was designed to receive a BankTransaction domain as a parameter, which contains the target id and the content to be modified, and the delete() method was designed to receive only the id of the target to be deleted as a parameter. So, I made those modifications.

Thank you. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant