Skip to content

feat: migrate AppDelegate to Swift and remove legacy files for improved architecture#660

Closed
lposen wants to merge 10 commits into
masterfrom
new-arch/ks-ios
Closed

feat: migrate AppDelegate to Swift and remove legacy files for improved architecture#660
lposen wants to merge 10 commits into
masterfrom
new-arch/ks-ios

Conversation

@lposen
Copy link
Copy Markdown
Contributor

@lposen lposen commented Jun 11, 2025

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented Jun 11, 2025

❌ 5 blocking issues (5 total)

Tool Category Rule Count
eslint Lint Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
3
eslint Lint Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. 2

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@@ -0,0 +1,113 @@
import { type TurboModule, TurboModuleRegistry } from 'react-native';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@@ -0,0 +1,4 @@
import { NativeEventEmitter, NativeModules } from 'react-native';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

Comment thread src/core/api/index.ts
@@ -0,0 +1,9 @@
import TurboIterableModule from './NativeRNIterableApi'; // new arch
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

) {
Iterable?.logger?.log('updateUser');

// @ts-ignore
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. [eslint:@typescript-eslint/ban-ts-comment]

Suggested change
// @ts-ignore
// @ts-expect-error

Replace "@ts-ignore" with "@ts-expect-error".

useInMemoryStorageForInApps: this.useInMemoryStorageForInApps,
// @ts-ignore
dataRegion: this.dataRegion,
// @ts-ignore
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. [eslint:@typescript-eslint/ban-ts-comment]

Suggested change
// @ts-ignore
// @ts-expect-error

Replace "@ts-ignore" with "@ts-expect-error".

@@ -0,0 +1,113 @@
import { type TurboModule, TurboModuleRegistry } from 'react-native';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@@ -0,0 +1,4 @@
import { NativeEventEmitter, NativeModules } from 'react-native';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

Comment thread src/core/api/index.ts
@@ -0,0 +1,9 @@
import TurboIterableModule from './NativeRNIterableApi'; // new arch
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

) {
Iterable?.logger?.log('updateUser');

// @ts-ignore
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. [eslint:@typescript-eslint/ban-ts-comment]

Suggested change
// @ts-ignore
// @ts-expect-error

Replace "@ts-ignore" with "@ts-expect-error".

useInMemoryStorageForInApps: this.useInMemoryStorageForInApps,
// @ts-ignore
dataRegion: this.dataRegion,
// @ts-ignore
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. [eslint:@typescript-eslint/ban-ts-comment]

Suggested change
// @ts-ignore
// @ts-expect-error

Replace "@ts-ignore" with "@ts-expect-error".

Base automatically changed from new-arch/master to master July 16, 2025 21:21
@lposen lposen closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant