Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-6665] updates get messages to pull messages from placement #611

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Jul 31, 2023

🔹 Jira Ticket(s) if any

✏️ Description

This pull request updates the syncMessages function to pull messages from the placement object in the payload.

@evantk91 evantk91 requested a review from Ayyanchira July 31, 2023 21:53
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 11.07% and project coverage change: -22.75% ⚠️

Comparison is base (f844696) 62.92% compared to head (0c73567) 40.17%.
Report is 6 commits behind head on embedded.

❗ Current head 0c73567 differs from pull request most recent head cd507b6. Consider uploading reports for the commit cd507b6 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           embedded     #611       +/-   ##
=============================================
- Coverage     62.92%   40.17%   -22.75%     
=============================================
  Files            68       72        +4     
  Lines          4070     4398      +328     
  Branches        469      494       +25     
=============================================
- Hits           2561     1767      -794     
- Misses         1257     2427     +1170     
+ Partials        252      204       -48     
Files Changed Coverage Δ
...com/iterable/iterableapi/EmbeddedImpressionData.kt 0.00% <0.00%> (ø)
...va/com/iterable/iterableapi/IterableConstants.java 0.00% <ø> (ø)
.../iterable/iterableapi/IterableEmbeddedPlacement.kt 0.00% <0.00%> (ø)
.../iterable/iterableapi/OfflineRequestProcessor.java 0.00% <0.00%> (-81.04%) ⬇️
...ain/java/com/iterable/iterableapi/IterableApi.java 33.92% <9.52%> (-27.45%) ⬇️
...om/iterable/iterableapi/IterableEmbeddedManager.kt 10.97% <10.97%> (ø)
...com/iterable/iterableapi/EmbeddedSessionManager.kt 12.69% <12.69%> (ø)
...va/com/iterable/iterableapi/IterableApiClient.java 39.40% <16.90%> (-36.66%) ⬇️
...om/iterable/iterableapi/IterableEmbeddedSession.kt 25.00% <25.00%> (ø)
...m/iterable/iterableapi/OnlineRequestProcessor.java 87.50% <100.00%> (+2.88%) ⬆️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from evan/MOB-6664-add-placement-class to embedded August 7, 2023 22:44
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@evantk91 evantk91 merged commit 4fd7118 into embedded Aug 8, 2023
4 checks passed
@evantk91 evantk91 deleted the evan/MOB-6665-update-SDK-methods-to-pull-messages-from-placement branch August 8, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants