Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 (CI): Use cibuildwheel for wheel building #79

Merged
merged 8 commits into from
Nov 12, 2024
Merged

🔧 (CI): Use cibuildwheel for wheel building #79

merged 8 commits into from
Nov 12, 2024

Conversation

Isotr0py
Copy link
Owner

@Isotr0py Isotr0py commented Nov 6, 2024

Related issue: #74

.github/workflows/release.yml Outdated Show resolved Hide resolved
@jfolz
Copy link

jfolz commented Nov 7, 2024

Re: qemu.

Since it's so terribly slow, I implemented separate jobs for different architectures (and PyPy) for one of my projects, see build_wheels.yml. The matrix is terrible, but it illustrates the concept :)

@Isotr0py
Copy link
Owner Author

Not sure if the regression performance related to my device, the performance of built wheel from CI with vendored looks good on another device:

/content/pillow-jpegxl-plugin
Quality: 98

Effort 1
  plugin    [size: 258714, duration: 0.408]
  reference [size: 258716, duration: 0.346]

Effort 2
  plugin    [size: 258714, duration: 0.327]
  reference [size: 258716, duration: 0.347]

Effort 3
  plugin    [size: 240657, duration: 0.482]
  reference [size: 240659, duration: 0.355]

Effort 4
  plugin    [size: 242940, duration: 0.585]
  reference [size: 242942, duration: 0.720]

Effort 5
  plugin    [size: 342423, duration: 0.943]
  reference [size: 342425, duration: 0.650]

Effort 6
  plugin    [size: 341787, duration: 0.764]
  reference [size: 341789, duration: 0.900]

Effort 7
  plugin    [size: 340736, duration: 0.825]
  reference [size: 340738, duration: 0.985]

Effort 8
  plugin    [size: 349518, duration: 4.144]
  reference [size: 349520, duration: 3.226]

Effort 9
  plugin    [size: 352912, duration: 4.956]
  reference [size: 352914, duration: 5.897]

Therefore, I'm going to merge this PR for Linux building CI first, and migrate Windows and MacOS CI in a seperate PR. :)
I will make a new release for python3.13 after supporting I;16 and F modes as well.

@jfolz @rphlo Thanks for your help very much!

@Isotr0py Isotr0py marked this pull request as ready for review November 12, 2024 06:32
@Isotr0py Isotr0py merged commit b0fb0e1 into main Nov 12, 2024
9 checks passed
@Isotr0py Isotr0py deleted the ci-build branch November 12, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants