Added editing cycle history #95
Conversation
src/modals/Menu.tsx
Outdated
| slot="start" | ||
| icon={createOutline} | ||
| <> | ||
| <EditModal |
There was a problem hiding this comment.
Just a my opinion, but you don't need to create separated file with EditModal component it you'll shorten the code and separate the logic between СalculationLogic and the component
There was a problem hiding this comment.
I think this modal should be left in a separate file. It has a lot of calculations, large code and has its own design.
Even after moving logic calculations.
There was a problem hiding this comment.
We discussed offline that you'll better to move all calc logic in the CalculationLogic file, making EditModal short enough to leave it inside Menu.tsx
|
I moved the calculations in the Also I added the following: then it counts as one cycle. After calculations and writing to the storage, it will look like this. Let's leave it that way for this version. |
src/modals/EditModal.tsx
Outdated
|
|
||
| return ( | ||
| date.getTime() < lastCycleFinish.getTime() || | ||
| date.getTime() <= nowDate.getTime() |
There was a problem hiding this comment.
Looks like this expression always will be truebecause any date will be lesser than now date
There was a problem hiding this comment.
No, because it is a condition for all calendar dates
There was a problem hiding this comment.
Understand, then could you please rename lastCycleFinish? Because now this variable looks like last cycle until today, but you mean that this cycle the end of the next expected cycle, which is calculated for the calendar
Closed #87
I added an edit that is in the menu.
Editing is done by adding or deleting marked days in the calendar. You can edit only up to the possible finish day of the current cycle.
I also added a native back button for it. But it only goes to the
home tab. But I think it will be enough for this version.Screenshots here:
