Use bulkaccess splitting from the library #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay, and refine error messages in tests
Updated Siemens.Simatic.S7.Webserver.API package to 3.2.1 and re-enabled its reference. Removed project reference to Webserver.API.csproj. Refactored WebApiConnector for improved readability and performance, including adding an ApiRequestSplitterByBytes instance that replaces the existing message splitting in this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
Directory.Packages.propsfile and theAXSharp.Connector.S71500.WebAPIproject to update package versions and refactor the codebase. The most significant changes include updating package versions, removing unused code, and refactoring theWebApiConnectorclass for improved readability and maintainability.Package Version Updates:
Microsoft.Extensions.DependencyInjection.Abstractionsto version9.0.2for bothnet9.0andnet8.0target frameworks inDirectory.Packages.props. [1] [2]Siemens.Simatic.S7.Webserver.APIto version3.2.1inDirectory.Packages.props.Code Removal:
ApiRequestsExtensionsclass fromApiRequestsExtensions.csas it was no longer needed.Refactoring:
WebApiConnectorclass inWebApiConnector.csto improve readability and maintainability:ApiRequestSplitterByBytesfor request handling. [1] [2]RequestHandlerandAntiThrottling. [1] [2]HandleCommFailuremethod.varwhere appropriate. [1] [2]RetryPolicyinitialization.ReadBatchAsyncandWriteBatchAsyncmethods to streamline the request processing logic. [1] [2]