-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPLC] [Test] Add scoping tests #6773
base: master
Are you sure you want to change the base?
[UPLC] [Test] Add scoping tests #6773
Conversation
31e82d6
to
95bbea6
Compare
95bbea6
to
cf7c231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but we have a Pass
data type (though currently only for PIR) where a Pass
is associated with pre- and post-conditions. Would it be better to express the scoping properties in Pass
instead of using this more ad-hoc way of testing?
The scoping tests are already rather complex, I'd rather not add any more complexity unless it's needed for something. Currently we only distinguish between
I don't feel like adding an abstraction on top of this will make anything simpler or more readable. Particularly given that the handling logic is deep within the scoping tests machinery, so abstracting it out of there won't be nice. |
cf7c231
to
e500ffd
Compare
This adds scoping tests for UPLC the same way we have them for PIR. It also tweaks the way the scoping machinery handles case-expressions for PIR.
I didn't stumble upon any unexpected behavior.