-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTxO-HD code-review work #1304
Open
jasagredo
wants to merge
24
commits into
utxo-hd-main
Choose a base branch
from
utxo-hd-code-review-work
base: utxo-hd-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UTxO-HD code-review work #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
nfrisby,
amesgen,
fraser-iohk and
dnadales
as code owners
November 14, 2024 10:56
This type for storing resources was reinventing the wheel: `quickcheck-dynamic` already keep track of resources by storing a `Var` for each action result. `IOSim` support for tests is also removed. It would be straightforward to revive `IOSim` support in the future, if necessary.
* Rename `MockState` to `MockMonad`. * Remove exception handler hoop jumping in `mBSClose` and `mBSVHClose`. * Tag `ReadAfterWrite` and `RangeReadAfterWrite` only once per action sequence. * Resolve some TODOs
I had initially decided it was best to replace uses of `ltcollapse` by some new `ltfoldMap` function, but after some thinking it's best to instead use `ltcollapse` as is, but removing the use of monoids there, which currently has no effect. The reason I think this is the right call is because ledger tables are currently a single-constructor newtype, and they will be for at least a while. We do not know what ledger tables will look like when we store more parts of the ledger state, so let's cross that bridge when we get there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists only to accumulate Code-review changes that we will merge into
utxo-hd-main
once the first review pass is done.