Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTxO-HD code-review work #1304

Open
wants to merge 24 commits into
base: utxo-hd-main
Choose a base branch
from
Open

Conversation

jasagredo
Copy link
Contributor

This PR exists only to accumulate Code-review changes that we will merge into utxo-hd-main once the first review pass is done.

jasagredo and others added 7 commits November 22, 2024 14:25
This type for storing resources was reinventing the wheel: `quickcheck-dynamic`
already keep track of resources by storing a `Var` for each action result.

`IOSim` support for tests is also removed. It would be straightforward to revive
`IOSim` support in the future, if necessary.
* Rename `MockState` to `MockMonad`.
* Remove exception handler hoop jumping in `mBSClose` and `mBSVHClose`.
* Tag `ReadAfterWrite` and `RangeReadAfterWrite` only once per action sequence.
* Resolve some TODOs
I had initially decided it was best to replace uses of `ltcollapse` by some new
`ltfoldMap` function, but after some thinking it's best to instead use
`ltcollapse` as is, but removing the use of monoids there, which currently has
no effect.

The reason I think this is the right call is because ledger tables are currently
a single-constructor newtype, and they will be for at least a while. We do not
know what ledger tables will look like when we store more parts of the ledger
state, so let's cross that bridge when we get there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants