Skip to content

Disable old redeemer deserialization #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2025
Merged

Disable old redeemer deserialization #5361

merged 3 commits into from
Oct 30, 2025

Conversation

@Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Oct 27, 2025 •
edited
Loading

Description

This PR disables the deprecated list deserializer for Redeemers.

close #5345

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw marked this pull request as ready for review October 27, 2025 14:05
@Soupstraw Soupstraw requested a review from a team as a code owner October 27, 2025 14:05
lehins
lehins reviewed Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what we needed. Could I ask you to add a test case that ensures this behavior for Conway and Dijkstra differs and doesn't change with time?

@Soupstraw Soupstraw force-pushed the jj/remove-invalid-redeemer-serialization branch from e567a10 to 9f7ccde Compare October 30, 2025 12:26
@Soupstraw Soupstraw force-pushed the jj/remove-invalid-redeemer-serialization branch from 9f7ccde to ac400ce Compare October 30, 2025 12:28
lehins
lehins approved these changes Oct 30, 2025
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice!!! Thank you!
I only added suggestions with minor improvements.

@Soupstraw @lehins
Review
3a83422 
Co-authored-by: Alexey Kuleshevich <[email protected]>
@Soupstraw Soupstraw force-pushed the jj/remove-invalid-redeemer-serialization branch from d171dab to 3a83422 Compare October 30, 2025 15:13
@Soupstraw Soupstraw enabled auto-merge (rebase) October 30, 2025 15:14
@Soupstraw Soupstraw merged commit 04632c6 into master Oct 30, 2025
120 of 122 checks passed
@Soupstraw Soupstraw deleted the jj/remove-invalid-redeemer-serialization branch October 30, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lehins lehins lehins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove support for invalid Redeemer serialization

3 participants

@Soupstraw @lehins