Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of crypto parametrization #4788

Open
wants to merge 23 commits into
base: tdammers/for-mlocked-kes-consensus
Choose a base branch
from

Conversation

Lucsanszky
Copy link
Contributor

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky
Copy link
Contributor Author

Opened a draft PR, since now it's a good time to discuss a few things and then we can proceed with cleaning up the commit history, resolving conflicts etc.

@Lucsanszky Lucsanszky force-pushed the lehins/get-rid-of-crypto-parametrization branch from 4db5713 to 05ab36c Compare December 9, 2024 16:55
@Lucsanszky Lucsanszky marked this pull request as ready for review December 9, 2024 17:09
@Lucsanszky Lucsanszky requested a review from a team as a code owner December 9, 2024 17:09
@Lucsanszky
Copy link
Contributor Author

Marking this ready for review.

A few things that still needs to be done:

  • Remove extraneous specialisations
  • Maybe run hlint --refactor as a rebase script to remove some extra parenthesis leftovers

@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch 2 times, most recently from 6a283af to c0de4cb Compare December 10, 2024 03:37
@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch from ef07c87 to 008df29 Compare December 11, 2024 02:28
@lehins lehins changed the base branch from master to tdammers/for-mlocked-kes-consensus December 11, 2024 02:31
Copy link
Contributor Author

@Lucsanszky Lucsanszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review progress tracker:

  • eras:
    • shelley
    • allegra
    • mary
    • alonzo
    • shelley-ma
    • babbage
    • conway 👍
  • libs:
    • cardano-ledger-api
    • cardano-ledger-conformance
    • cardano-ledger-core
    • cardano-ledger-test
    • cardano-protocol-tpraos
    • ledger-state

@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 2 times, most recently from e8b1adb to d0cb5c5 Compare December 11, 2024 19:44
@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch 2 times, most recently from 2d2d735 to 03a7111 Compare December 11, 2024 21:59
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch from 210f7d6 to 26784d7 Compare December 11, 2024 22:12
@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch from 03a7111 to 6876f1b Compare December 11, 2024 22:13
@lehins
Copy link
Collaborator

lehins commented Dec 12, 2024

I've reviewed the whole PR.
Now we just need to wait for #4699 to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants