Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cabal-gild to format cabal files #4787

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Use cabal-gild to format cabal files #4787

merged 4 commits into from
Dec 10, 2024

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Dec 6, 2024

Description

Setup cabal-gild in our scripts and CI and reformat all cabal files using it.
Closes #4704

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/cabal-gild branch 8 times, most recently from d6fad1f to 7534510 Compare December 9, 2024 16:27
@teodanciu teodanciu marked this pull request as ready for review December 9, 2024 16:29
@teodanciu teodanciu requested a review from a team as a code owner December 9, 2024 16:29
@teodanciu teodanciu force-pushed the td/cabal-gild branch 3 times, most recently from 40aa729 to 9b28491 Compare December 9, 2024 16:51
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!!!!
Thank you!

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
scripts/cabal-format.sh Outdated Show resolved Hide resolved
scripts/cabal-format.sh Outdated Show resolved Hide resolved
scripts/cabal-format.sh Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
scripts/cabal-format.sh Outdated Show resolved Hide resolved
@teodanciu teodanciu enabled auto-merge December 10, 2024 15:33
@teodanciu teodanciu merged commit fba33b9 into master Dec 10, 2024
147 of 148 checks passed
@teodanciu teodanciu deleted the td/cabal-gild branch December 10, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using deprecated cabal format
2 participants