Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cardano-base dependency #4699

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Upgrade cardano-base dependency #4699

wants to merge 5 commits into from
+124 −315

Conversation

tdammers
Copy link

Description

Upgrade dependency on cardano-base in order to be compatible with upcoming versions of ouroboros-consensus.
In current versions of cardano-base, KES sign keys are stored in mlocked memory, and all operations involving them must now happen in IO or ST. In order to facilitate existing pure code that isn't security-critical (e.g., generating mock data for testing purposes), the previous pure KES API is now provided as UnsoundPureKES, which we use here.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

lehins
lehins requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdammers Please get rid of any changes related to serialization.
I wish you would have asked me before you went on wasting a lot of time on introducing all those changes.

We need to get rid of all KES related serialization form ledger, since ledger codebase does not depend on KES at all. So, please revert all of the additions with respect to KES and get rid of any serialization functionality for KES that was provided before

eras/shelley/impl/src/Cardano/Ledger/Shelley/API/Types.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Crypto.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/cardano-ledger-binary.cabal Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/cardano-ledger-binary.cabal Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/cardano-ledger-binary.cabal Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/cardano-ledger-binary.cabal Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/cardano-ledger-binary.cabal Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Crypto.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Crypto.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/RoundTripSpec.hs Outdated Show resolved Hide resolved
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 5 times, most recently from cd58e1d to e2f0944 Compare October 31, 2024 04:08
@lehins lehins changed the base branch from master to lehins/update-index-state October 31, 2024 15:08
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 2 times, most recently from 890a734 to f1c33e4 Compare October 31, 2024 16:36
Base automatically changed from lehins/update-index-state to master October 31, 2024 20:35
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 2 times, most recently from 15f7ecd to c33d9da Compare October 31, 2024 21:23
@neilmayhew neilmayhew force-pushed the tdammers/for-mlocked-kes-consensus branch from c33d9da to 41a6cef Compare November 13, 2024 05:07
@lehins lehins mentioned this pull request Nov 14, 2024
Open
@neilmayhew neilmayhew force-pushed the tdammers/for-mlocked-kes-consensus branch from 41a6cef to 12d29c9 Compare November 16, 2024 00:20
@neilmayhew
Copy link
Contributor

This now passes hydra CI but fails to build locally with nix develop and cabal. The Add a workaround the fact plutus-tx-plugin is "special" commit makes the local build work but causes a true nix build to fail. We will probably need help from DevX to solve this.

@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 2 times, most recently from d0828b1 to 1048b45 Compare November 20, 2024 00:36
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 5 times, most recently from c6cab50 to acf5734 Compare December 11, 2024 02:03
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch from acf5734 to e8b1adb Compare December 11, 2024 19:23
tdammers and others added 2 commits December 11, 2024 12:44
@tdammers @lehins
Upgrade cardano-base dependency
f88be0b
@lehins
Add a workaround for plutus-tx-plugin
d0cb5c5 
Looks like `plutus-tx-plugin` depends on `ghc` package and it seems that
new dependencies brought in with `cardano-crypto-class-2.2` create a
conflict due to `stm` version used with `ghc-9.6` being incompatible.
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch from e8b1adb to d0cb5c5 Compare December 11, 2024 19:44
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch from 210f7d6 to 26784d7 Compare December 11, 2024 22:12
@lehins lehins mentioned this pull request Dec 12, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdammers @neilmayhew @lehins