Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts sharing coders #4222

Closed
wants to merge 5 commits into from
Closed

Ts sharing coders #4222

wants to merge 5 commits into from

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Mar 28, 2024

Extends the Coders library to handle Sharing on the decode side.
Adds some DecShareCBOR instances as described in issue #3486 using the new tools

Began to address the problems described in issue #4192, about serializing CompactForm MultiAsset, without affecting backward compatibility.

A large part of the changes have to do with the following changes

  1. replacing Ann with Pure
  2. replacing (<!*) with (<!>)

The original operators Ann and (<!*) had to do the the Annotator type, but the ones have been generalized to work with any Applicative functor. Including the monad (StateT (Share b) (Decoder s) b) which is the basis for Sharing.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@TimSheard TimSheard force-pushed the ts-sharing-coders branch 6 times, most recently from 4211d1d to 836b3cd Compare April 4, 2024 01:30
@lehins
Copy link
Collaborator

lehins commented Oct 17, 2024

I am closing this PR as we will not be using Coders with Sharing. The plan is to create a different interface for ledger state serialization. See #3220

@lehins lehins closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants