-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-testnet-data: take optional node configuration file as input and check/add genesis hashes and paths #908
create-testnet-data: take optional node configuration file as input and check/add genesis hashes and paths #908
Conversation
c1d5553
to
1b5e0f1
Compare
4b6d12c
to
b75da64
Compare
6723d62
to
5181d0a
Compare
5181d0a
to
37e4c0c
Compare
37e4c0c
to
d0ae0cd
Compare
7efbed3
to
1c55a7c
Compare
072a26a
to
95ffdc8
Compare
28738b1
to
1fad533
Compare
cardano-cli/test/cardano-cli-golden/Test/Golden/CreateTestnetData.hs
Outdated
Show resolved
Hide resolved
c367d39
to
6a7e7f6
Compare
6a7e7f6
to
e697e94
Compare
…or genesis hashes and paths
e697e94
to
8bea6eb
Compare
8bea6eb
to
ce9f979
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functionality should exist as a separate command
liftIO $ LBS.writeFile alonzoGenesisPath $ Aeson.encodePretty alonzoGenesis | ||
|
||
case specNodeConfig of | ||
Nothing -> {- Don't do anything for now -} pure () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use case for having these overrides? We are bundling too many things into a single command. addOrCheckHash
gives us a hint that this can and should exist as separate command to check the node configuration file is correct and simply leave create-testnet-data
to be responsible for creating a node configuration file. Otherwise we have all this additional logic that makes things unnecessarily more complex. This grows with the more "overrides" we put into a command.
Changelog
Context
How to trust this PR
cardano-testnet-test
with this PR locally (using this branch oncardano-node
: https://github.com/IntersectMBO/cardano-node/commits/smelc/use-create-testnet-data-hash-generation-feature/)Checklist