Enable PR number validation in CI#1382
Merged
carbolymer merged 1 commit intoMay 21, 2026
Merged
Conversation
carbolymer
requested review from
a team,
Jimbo4350,
disassembler,
kevinhammond,
newhoggy and
palas
as code owners
carbolymer
force-pushed
the
mgalazyn/chore/enable-pr-number-validation-ci-check
branch
from
989143a to
fc8d92c
Compare
There was a problem hiding this comment.
Pull request overview
This PR tightens CI validation for changelog fragments by enabling PR-number checks in the Herald validation workflow, and removes a legacy cardano-dev configuration file that appears unused in this repository (the repo uses .herald.yml for Herald configuration).
Changes:
- Enable Herald’s default PR number validation in the changelog-fragment CI check by removing the
pr: falseoverride. - Remove the obsolete
.cardano-dev.yamlconfiguration file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/check-pr-changelog.yml |
Enables PR-number validation by relying on Herald’s default validation behavior (removes pr: false). |
.cardano-dev.yaml |
Deletes an apparently unused legacy config file (no in-repo references found). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jimbo4350
approved these changes
May 20, 2026
carbolymer
deleted the
mgalazyn/chore/enable-pr-number-validation-ci-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Enable PR number validation in CI
Checklist
.changes/