Add Ord constraint on CertVRF in VRFAlgorithm#658
Merged
Conversation
Ord CertVRF constraint to VRFAlgorithmEq constraint on CertVRF in VRFAlgorithm to Ord
Eq constraint on CertVRF in VRFAlgorithm to Ord Ord constraint on CertVRF in VRFAlgorithm
Also add `Ord` instances to the `CertVRF`s of the three `VRFAlgorithm` instances
5ea8c67 to
6ed7596
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to be able to store ledger predicate failures in a
Set, which requires anOrdconstraint. Some of these failures transitively embed VRF certs so they too need to haveOrdinstances.This change adds
Ordinstances for the three types of VRF provided in base. It also upgrades theEqconstraint toOrdin theVRFAlgorithmclass to avoid having to repeat more specific constraints in many places in the ledger codebase.Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)