Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new witness api #763

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Introduce new witness api #763

wants to merge 1 commit into from

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    <insert-changelog-description-here>
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 25, 2025
View reviewed changes
cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs
@@ -0,0 +1,484 @@
{-# LANGUAGE AllowAmbiguousTypes #-}
{-# LANGUAGE DataKinds #-}
{-# LANGUAGE EmptyCase #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs:3:1-26: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE EmptyCase #-}
  
Perhaps you should remove it.
cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs
{-# LANGUAGE FlexibleContexts #-}
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE GADTs #-}
{-# LANGUAGE KindSignatures #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs:7:1-31: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE KindSignatures #-}
  
Perhaps you should remove it.
  
Note: Extension KindSignatures is implied by TypeFamilies
cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs
{-# LANGUAGE RankNTypes #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE StandaloneDeriving #-}
{-# LANGUAGE TypeApplications #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs:14:1-33: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE TypeApplications #-}
  
Perhaps you should remove it.
cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE StandaloneDeriving #-}
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE TypeFamilies #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs:15:1-29: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE TypeFamilies #-}
  
Perhaps you should remove it.
  
Note: may require {-#&nbsp;LANGUAGE&nbsp;MonoLocalBinds&nbsp;#-} adding to the top of the file, may require {-#&nbsp;LANGUAGE&nbsp;ExplicitNamespaces&nbsp;#-} adding to the top of the file, Extension TypeFamilies is implied by TypeFamilyDependencies
cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs
Comment on lines +415 to +512
createIndexedPlutusScriptWitness index witnessable pSwit =
IndexedPlutusScriptWitness witnessable (toPlutusScriptPurpose index witnessable) pSwit

Check warning

Code scanning / HLint

Eta reduce Warning

cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/ScriptWitness.hs:(511,1)-(512,88): Warning: Eta reduce
  
Found:
  createIndexedPlutusScriptWitness index witnessable pSwit
    = IndexedPlutusScriptWitness
        witnessable (toPlutusScriptPurpose index witnessable) pSwit
  
Perhaps:
  createIndexedPlutusScriptWitness index witnessable
    = IndexedPlutusScriptWitness
        witnessable (toPlutusScriptPurpose index witnessable)
cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs
{-# LANGUAGE GADTs #-}
{-# LANGUAGE LambdaCase #-}
{-# LANGUAGE NamedFieldPuns #-}
{-# LANGUAGE PatternSynonyms #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs:10:1-32: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE PatternSynonyms #-}
  
Perhaps you should remove it.
cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs
{-# LANGUAGE RankNTypes #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE StandaloneDeriving #-}
{-# LANGUAGE TupleSections #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs:14:1-30: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE TupleSections #-}
  
Perhaps you should remove it.
cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE StandaloneDeriving #-}
{-# LANGUAGE TupleSections #-}
{-# LANGUAGE TypeApplications #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs:15:1-33: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE TypeApplications #-}
  
Perhaps you should remove it.
cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs
{-# LANGUAGE TupleSections #-}
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeOperators #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs:17:1-30: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE TypeOperators #-}
  
Perhaps you should remove it.
  
Note: may require {-#&nbsp;LANGUAGE&nbsp;ExplicitNamespaces&nbsp;#-} adding to the top of the file
cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE ViewPatterns #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Tx/BuildTxWith.hs:18:1-29: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE ViewPatterns #-}
  
Perhaps you should remove it.
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-scripts-api branch from 41613bf to ee59574 Compare February 25, 2025 19:35
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 25, 2025
View reviewed changes
cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/Shim/LegacyScripts.hs
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeFamilyDependencies #-}
{-# LANGUAGE InstanceSigs #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning

cardano-api/src/Cardano/Api/Internal/Experimental/Plutus/Shim/LegacyScripts.hs:15:1-29: Warning: Unused LANGUAGE pragma
  
Found:
  {-# LANGUAGE InstanceSigs #-}
  
Perhaps you should remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts will be requested when the pull request is marked ready for review dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd will be requested when the pull request is marked ready for review erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy will be requested when the pull request is marked ready for review newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer will be requested when the pull request is marked ready for review carbolymer is a code owner

@smelc smelc Awaiting requested review from smelc smelc will be requested when the pull request is marked ready for review smelc is a code owner

@palas palas Awaiting requested review from palas palas will be requested when the pull request is marked ready for review palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond will be requested when the pull request is marked ready for review kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara will be requested when the pull request is marked ready for review CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler will be requested when the pull request is marked ready for review disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jimbo4350