Fix: NPD & UB in CIccTagXmlFloatNum<T, A, Tsig>::ParseXml() #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsscx
added
PR
xsscx
approved these changes
Jan 22, 2026
Member
xsscx
left a comment
xsscx
left a comment
There was a problem hiding this comment.
Maintainer Review
Wed Jan 21 20:53:25 EST 2026
9f134c4 (HEAD -> pr-513, origin/issue-484) check pointer before dereferencing
iccFromXml ub-member-access-null-pointer-struct-xmlnode.xml oops.icc
Expected Output
Unknown Profile Header attribute: PnofileFlags=""
Unable to Parse "float16ArrayType" (float16NumberType) Tag on line 62
Unable to Parse 'ub-member-access-null-pointer-struct-xmlnode.xml'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484
Pull Request Checklist