-
Notifications
You must be signed in to change notification settings - Fork 63
Fix/fix calculate power law r2 #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ChenZiHong-Gavin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the power law R-squared calculation within the graph evaluation module, ensuring accurate statistical analysis. It also refactors environment variable loading for better application structure and enhances the WebUI's configuration with default backend settings and output saving for the generation process. These changes collectively improve the robustness, maintainability, and functionality of the system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a critical bug in the power-law R² calculation by correctly using the rvalue from scipy.stats.linregress instead of the slope. It also includes several related fixes and improvements, such as moving the load_dotenv call to a more appropriate entry point, and updating the web UI configuration to ensure correct pipeline execution and output handling. My review includes one suggestion to improve the flexibility of the web UI by avoiding hardcoded storage backend configurations.
| config = { | ||
| "global_params": { | ||
| "working_dir": working_dir, | ||
| "graph_backend": "kuzu", | ||
| "kv_backend": "rocksdb", | ||
| }, | ||
| "nodes": nodes, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The graph_backend and kv_backend are hardcoded in the configuration. This reduces the flexibility of the web application, as users cannot easily switch to other supported backends (e.g., networkx for graphs, json_kv for key-value stores) without modifying the source code. It would be better to expose these as configurable options in the UI, perhaps by adding them to the WebuiParams dataclass.
No description provided.