Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 2 additions & 47 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
TAG: "openmmlab/lmdeploy:latest-${{matrix.cuda_version}}"
steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{github.event.inputs.repo_ref}}
- name: Free disk space
Expand Down Expand Up @@ -96,51 +96,6 @@ jobs:
docker tag $TAG $RELEASE_TAG
docker push $RELEASE_TAG
publish_dev_docker_image:
runs-on: ubuntu-latest
environment: 'prod'
env:
TAG_PREFIX: "openmmlab/lmdeploy"
TAG: "openmmlab/lmdeploy:dev"
steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
ref: ${{github.event.inputs.repo_ref}}
- name: Free disk space
uses: jlumbroso/free-disk-space@main
with:
# This might remove tools that are actually needed, if set to "true" but frees about 6 GB
tool-cache: false
docker-images: false
# All of these default to true, but feel free to set to "false" if necessary for your workflow
android: true
dotnet: true
haskell: true
large-packages: true
swap-storage: false
- name: Get docker info
run: |
docker info
# remove http extraheader
git config --local --unset "http.https://github.com/.extraheader"
- name: Login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Update docker TAG from workflow input
if: github.event_name == 'workflow_dispatch'
run: |
export TAG=$TAG_PREFIX:${{github.event.inputs.image_tag}}-dev
echo $TAG
echo "TAG=${TAG}" >> $GITHUB_ENV
- name: Build and push Docker image
run: |
echo $TAG
docker build . -f docker/Dockerfile -t ${TAG} --build-arg IMAGE_TYPE=dev
docker push $TAG
publish_ascend_docker_image:
runs-on: ubuntu-latest
environment: 'prod'
Expand All @@ -149,7 +104,7 @@ jobs:
TAG: "openmmlab/lmdeploy:ascend"
steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{github.event.inputs.repo_ref}}
- name: Free disk space
Expand Down
53 changes: 53 additions & 0 deletions .github/workflows/docker_dev.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
name: publish-dev-docker

on:
workflow_dispatch:
inputs:
repo_ref:
required: false
description: 'Set branch or tag or commit id. Default is "main"'
type: string
default: 'main'

jobs:
publish_dev_docker_image:
runs-on: ubuntu-latest
environment: 'prod'
env:
TAG: "openmmlab/lmdeploy:dev-cu12.8"
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
ref: ${{ github.event.inputs.repo_ref }}

- name: Free disk space
uses: jlumbroso/free-disk-space@v1.3.1
with:
# This might remove tools that are actually needed, if set to "true" but frees about 6 GB
tool-cache: false
docker-images: false
# All of these default to true, but feel free to set to "false" if necessary for your workflow
android: true
dotnet: true
haskell: true
large-packages: true
swap-storage: false

- name: Get docker info
run: |
docker info
# remove http extraheader
git config --local --unset "http.https://github.com/.extraheader"

- name: Login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Build and push Docker image
run: |
echo $TAG
docker build . -f docker/Dockerfile_dev -t ${TAG}
docker push $TAG
Comment on lines +49 to +53
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow builds the dev image using docker/Dockerfile_dev, but the previously removed publish_dev_docker_image job built from docker/Dockerfile with --build-arg IMAGE_TYPE=dev (and implicitly different defaults like CUDA_VERSION/PYTHON_VERSION). That changes the contents/behavior of the published dev tag, not just when it’s built. If the goal is only to make the existing dev image manual, consider switching this workflow back to the same Dockerfile/build-args as before; otherwise, please update the PR title/description (and possibly the tag name) to reflect that the dev image definition has changed.

Copilot uses AI. Check for mistakes.
Loading