-
Notifications
You must be signed in to change notification settings - Fork 535
[WIP]: vl prefix caching #3389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RunningLeon
wants to merge
11
commits into
InternLM:main
Choose a base branch
from
RunningLeon:vl-prefix-caching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP]: vl prefix caching #3389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
lmdeploy/vl/model/deepseek.py:91
- [nitpick] Consider renaming the variable 'params' to 'image_params' for improved clarity in the context of image preprocessing.
for image, params in images:
lmdeploy/pytorch/paging/block_trie.py:81
- Accessing 'self.parent' in repr may raise an AttributeError since no getter for 'parent' is defined; consider using 'self._parent' or adding an appropriate property.
f'num_children={len(self.children)}, is_root={self.parent is None}, '
lmdeploy/api.py:71
- [nitpick] The automatic disabling of prefix caching for VLM has been removed here; please confirm that the VLM backend indeed supports prefix caching to avoid unexpected behavior.
_, pipeline_class = get_task(model_path)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist