support loading model with user input params (turbomind)#3204
Closed
irexyc wants to merge 5 commits intoInternLM:mainfrom
Closed
support loading model with user input params (turbomind)#3204irexyc wants to merge 5 commits intoInternLM:mainfrom
irexyc wants to merge 5 commits intoInternLM:mainfrom
Conversation
lvhan028
reviewed
Mar 4, 2025
| num_tokens_per_iter: int = 0 | ||
| max_prefill_iters: int = 1 | ||
| communicator: str = 'nccl' | ||
| model_params_que: Any = None |
Collaborator
There was a problem hiding this comment.
I agree with using a queue as a pipeline for data transmission, but I do not agree with making this parameter an engine parameter, as the two are completely unrelated
Can it be an argument in AsyncEngine.init?
@lzhangzz any suggestions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Motivated by #3146
A usage demo