Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to indicate currency at impression or deal level #113

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

benhumphry
Copy link
Contributor

Add 'cur' parameters for deals and impressions to support Asian mobile use cases

@anderagakura
Copy link

@benhumphry Is bidfloorcur not already enough at impression or deal level?

@benhumphry
Copy link
Contributor Author

@benhumphry Is bidfloorcur not already enough at impression or deal level?

I can double check with my clients; doesn't bidfloorcur assume a bid floor?

@anderagakura
Copy link

@benhumphry bidfloor sets the minimum bid while bidfloorcur sets the currency. But in general, in the bid request you have only cur at impression level to set the currency of the whole bid request.

@benhumphry
Copy link
Contributor Author

Understood; the requirement here is to allow more granular setting of currency > @benhumphry bidfloor sets the minimum bid while bidfloorcur sets the currency. But in general, in the bid request you have only cur at impression level to set the currency of the whole bid request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants