Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load single plot areas on creation #4490

Merged
merged 2 commits into from
Sep 14, 2024
Merged

fix: load single plot areas on creation #4490

merged 2 commits into from
Sep 14, 2024

Conversation

PierreSchwang
Copy link
Member

Overview

Fixes #4467

Description

That change was made quite often in the last couple of years. adWorld returns false if the world is already registered in PS - which it is when creating a single area in an existing world.

Submitter Checklist

Preview Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner September 1, 2024 15:04
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Sep 1, 2024
@SirYwell
Copy link
Member

SirYwell commented Sep 1, 2024

It seems like it's currently possible to create single plot areas overlapping with others - there is an error, but the area gets created nonetheless.

@PierreSchwang
Copy link
Member Author

It seems like it's currently possible to create single plot areas overlapping with others - there is an error, but the area gets created nonetheless.

Shouldn't be caused by my change, no? The overlapping check is handled in the command itself, before creating the area (and way before loading the area). Can address that though

@SirYwell
Copy link
Member

SirYwell commented Sep 1, 2024

Shouldn't be caused by my change, no? The overlapping check is handled in the command itself, before creating the area (and way before loading the area). Can address that though

Most likely not related, but I think it would be good to fix it here too.

@NotMyFault NotMyFault merged commit 001ae78 into main Sep 14, 2024
10 checks passed
@NotMyFault NotMyFault deleted the fix/4467 branch September 14, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/plot area single not creating the plot area
4 participants