Prevent vanished players from being in plot kick autocompletion #4485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4484
Description
I added the parameter
PlotPlayer<?> issuer
to the methodTabCompletions#completePlayersInPlot
to be able to call the PlotPlayer#canSee method. Moreover, it makes sense to me that a player should be supplied to this method to have its "personalized" completions.I didn't add null check in my if block as the parameter is already annotated with
@NonNull
.Submitter Checklist