fix: rename minecart EntityType enum constants

[PierreSchwang]

Overview

Fixes #4462

Description

Adjusted the enum constant names to the new naming. Only working 1.20 onwards - though backwards compatibility doesn't seem to exist for a while now

PlotSquared/Bukkit/src/main/java/com/plotsquared/bukkit/listener/PlayerEventListener.java

Lines 168 to 175 in 895cf0d

	private static final Set<Material> MINECARTS = Set.of(
	Material.MINECART,
	Material.TNT_MINECART,
	Material.CHEST_MINECART,
	Material.COMMAND_BLOCK_MINECART,
	Material.FURNACE_MINECART,
	Material.HOPPER_MINECART
	);

Submitter Checklist

Preview Give feedback

1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
2. Ensure that the pull request title represents the desired changelog entry.
3. New public fields and methods are annotated with @since TODO.
4. I read and followed the contribution guidelines.

[SirYwell]

As we're using strings there, it should be possible to just list both variants. Would that make sense?

[PierreSchwang]

As we're using strings there, it should be possible to just list both variants. Would that make sense?

I actually did that first, but removed the "old" ones as PS does not really has backwards compatibility anymore due to the usage of the Enum constants in other classes (as linked in the initial PR comment)

[SirYwell]

Does that code actually fail on older versions? Do you know when it was renamed?

[PierreSchwang]

Does that code actually fail on older versions? Do you know when it was renamed?

Can't really say - would be worth testing though. Rename happened in 1.20 iirc

[SirYwell]

Ah, the names in Material are older, those weren't renamed. So I think having old and new names here makes sense.

[PierreSchwang]

Oh yeah, I see. I'm dumb. I compared the EntityType against the Material lol. Will fix