Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: get rid of guice overhead when accessing the player & world manager #4409

Merged
merged 1 commit into from
May 1, 2024

Conversation

Vrganj
Copy link
Contributor

@Vrganj Vrganj commented Apr 21, 2024

Overview

Description

Return already injected fields in BukkitPlatform to avoid slow
Injector access. Should speed up pretty much everything.

See #3315 for more information

Submitter Checklist

Preview Give feedback

@Vrganj Vrganj requested a review from a team as a code owner April 21, 2024 12:16
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Apr 21, 2024
@Vrganj Vrganj changed the title Return already injected fields to skip slow Injector access perf: get rid of guice overhead when accessing the player & world manager Apr 21, 2024
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@NotMyFault NotMyFault merged commit 6ef1163 into IntellectualSites:main May 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants