chore: mitigate possible future sqlite driver problems #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
reviewed
Oct 6, 2023
Core/src/main/java/com/plotsquared/core/database/SQLManager.java
Outdated
Show resolved
Hide resolved
NotMyFault
approved these changes
Oct 7, 2023
SirYwell
approved these changes
Oct 8, 2023
SirYwell
pushed a commit
that referenced
this pull request
Nov 16, 2023
* chore: mitigate possible future sqlite driver problems * chore/feat: log driver version on error --------- Co-authored-by: Alexander Brandes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just to be on the safer side, if https://github.com/xerial/sqlite-jdbc/releases/tag/3.43.0.0 is embedded again into Spigot / CB / Paper.
Checks if Statement#getGeneratedKeys is supported by the driver otherwise falls back on sqlite drivers using the RETURN statement on inserts. When using MySQL and getGeneratedKeys is not supported, well - that's a whole other story (but that's a very unlikely event).
Tested using latest paper and paper build 207 with mysql and sqlite.
Submitter Checklist