Support array_like low/high bounds for randint - #168
Open
vlad-perevezentsev wants to merge 9 commits into
Open
Conversation
vlad-perevezentsev
requested review from
antonwolfy,
jharlow-intel,
ndgrigorian and
xaleryb
as code owners
September 1, 2026 13:41
Collaborator
|
@vlad-perevezentsev |
ndgrigorian
reviewed
Sep 2, 2026
|
|
||
| Generate a 2 by 4 array using broadcasting with dtype of uint8 | ||
|
|
||
| >>> mkl_random.randint([1, 3, 5, 7], [[10], [20]], dtype=numpy.uint8) |
Collaborator
There was a problem hiding this comment.
Suggested change
| >>> mkl_random.randint([1, 3, 5, 7], [[10], [20]], dtype=numpy.uint8) | |
| >>> mkl_random.randint([1, 3, 5, 7], [[10], [20]], dtype=np.uint8) |
aligns with rest of the file
ndgrigorian
reviewed
Sep 2, 2026
Comment on lines
+2308
to
+2314
| max_high = int(np.max(high_b)) | ||
| if int(np.min(low_b)) < lowbnd: | ||
| raise ValueError(f"low is out of bounds for {_dtype.name}") | ||
| if max_high > highbnd: | ||
| raise ValueError(f"high is out of bounds for {_dtype.name}") | ||
| if np.any(low_b >= high_b): | ||
| raise ValueError("low >= high") |
Collaborator
There was a problem hiding this comment.
NumPy approaches this validation a bit differently:
https://github.com/numpy/numpy/blob/2f8bc80b22478d35627856679d0eaf876688ca39/numpy/random/_bounded_integers.pyx.in
I wonder if it's more efficient, since it uses the original arrays instead of broadcast arrays
Collaborator
|
@vlad-perevezentsev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
array_likelow/high support torandintto align withnumpy.random.RandomState.randintIt adds new C routines
irk_rand_<type>_broadcastfor all 9 integer dtypes, drawing per-element integers over [low, high) withLemire's multiply-shift(the same method as NumPy).An earlier
masked-rejectionversion benchmarked slower so it was replaced.A
mulhihelper returns the high half of the product becauseLemirecomputesword × rangewhich overflows the type so the 64-bit case uses a 32-bit schoolbook multiply.It also groups all
randinttests intoTestRandint classand adds new ones.