Skip to content

Conversation

K4rian
Copy link
Contributor

@K4rian K4rian commented Feb 16, 2025

This PR makes the Dosh throw delay and minimum throw amount configurable in the .ini file.

  • fDoshThrowDelay - Time between throws (in seconds).
  • iDoshThrowMinAmount - Minimum dosh to throw at once.

This should give server admins more control, especially on private servers.

Thanks for your hard work!

@Shtoyan Shtoyan self-assigned this Feb 16, 2025
@Shtoyan
Copy link
Member

Shtoyan commented Feb 24, 2025

Thanks for your proposal, but I'm a bit unsure about fDoshThrowDelay. This fix was calculated so even if 6 people try hard to spam dosh throwing, it will be not enough to bypass blocking volumes. If we allow people to tweak the delay - the fix will be pointless.

@K4rian
Copy link
Contributor Author

K4rian commented Feb 26, 2025

Hey,

You mentioned a bug/exploit that I'm not aware of. Are you saying that players can pass through the walls/obstacles by creating a big stash of Dosh? I didn't know about that since I never tried to cheat (nor have the people I play with).
Your modification's good thing, but it uses a global timer for all players, which makes Dosh sharing quite painful on higher difficulties. Maybe create a per-player timer instead? Not sure if that would be easy with the Unflect limitations.

Thanks for your time.

@K4rian
Copy link
Contributor Author

K4rian commented Feb 28, 2025

I've implemented a per-player limiter on my testing branch, and it’s working well so far (tested with 2 players).
However, it hasn't been fully tested with a full party yet.

Here are some code highlights:

Utility.uc#CanPlayerTossCash

Utility.uc#ResetCashTossLimiters

hookGT.uc#InitGame

hookPawn.uc#TossCash

@Shtoyan
Copy link
Member

Shtoyan commented Mar 8, 2025

You mentioned a bug/exploit that I'm not aware of.

https://insultingpros.github.io/KF1066/#/Critical/DoshMadness

I've implemented a per-player limiter on my testing branch, and it’s working well so far (tested with 2 players). However, it hasn't been fully tested with a full party yet.

Add commits to this branch, I'll check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants