Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itk.image() to itk.output() in _type_aliases.py #742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GingerSpacetail
Copy link

I'm not sure yet, as the whole itk module is currently not working for me... But meanwhile you might want to check if this line should be updated to match the fact that itk.image() is deprecated, and we should use itk.output() instead

https://github.com/InsightSoftwareConsortium/ITK/blob/2a1265d75f96ff7a072791629ff23b8c42123b3d/Wrapping/Generators/Python/itk/support/extras.py#L137

I'm not sure yet, as the whole itk module is currently not working for me...
But meanwhile you might want to check if this line should be updated to match the fact that itk.image() is deprecated, and we should use itk.output() instead

https://github.com/InsightSoftwareConsortium/ITK/blob/2a1265d75f96ff7a072791629ff23b8c42123b3d/Wrapping/Generators/Python/itk/support/extras.py#L137
@thewtex
Copy link
Member

thewtex commented Apr 17, 2024

Hi, thanks for the patch!

@thewtex
Copy link
Member

thewtex commented Apr 17, 2024

What issue are you seeing?

Note that itk.Image identifies a type, itk.image is a function to return the image instance that is either an itk.Image instance directly or the instance that would be produced by an itk filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants