Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Bump ITK to 5.4 Release Candidate 2 #419

Merged
merged 3 commits into from
Oct 30, 2023
Merged

ENH: Bump ITK to 5.4 Release Candidate 2 #419

merged 3 commits into from
Oct 30, 2023

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Oct 20, 2023

No description provided.

@thewtex thewtex requested a review from tbirdso October 20, 2023 17:51
@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Oct 20, 2023
tbirdso
tbirdso approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

jhlegarreta
jhlegarreta approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a commit message body.

@thewtex
Copy link
Member Author

thewtex commented Oct 24, 2023

The failing test, ConvertImageWithLabelsToShapeLabelMapTest, crashes on Windows sometimes in CI:

https://open.cdash.org/viewTest.php?onlyfailed&buildid=9080086
https://open.cdash.org/viewTest.php?onlyfailed&buildid=9079561

but it also passed:

https://open.cdash.org/viewTest.php?onlydelta&buildid=9079599

and it always passed on repeated runs locally.

However, the output of the test locally and CI is not correct, 16 objects or 10 objects when it should be 2 objects. I am performing a bisect on this.

I see ConvertImageToLabelMapTest also failed once on Windows:

https://open.cdash.org/viewTest.php?onlyfailed&buildid=9079572

@thewtex
ENH: Bump ITK to 5.4 Release Candidate 2
e404022 
The superbuild, python package and CI tests now use ITK 5.3 RC 2.
@thewtex
Copy link
Member Author

thewtex commented Oct 30, 2023

I'm missing a commit message body.

@jhlegarreta fixed :-)

@thewtex
ENH: Add PASS_REGULAR_EXPRESION to ConvertImageWithLabelsToShapeLabelMap
84fb315 
Ensure we are not getting an incorrect object count.
@thewtex
BUG: Disable ConvertImageWithLabelsToShapeLabelMapTest on Windows
db481ba 
Tracked in:

  InsightSoftwareConsortium#420

Checking various versions from ITK 4.13 to ITK 5.3, this was producing the wrong output (a much larger object count) on Windows. In ITK 5.4 RC 2, the test will occasionally crash.
@github-actions github-actions bot added the area:Filtering Issues affecting the Filtering module label Oct 30, 2023
@thewtex
Copy link
Member Author

thewtex commented Oct 30, 2023

After spending some time investigating the failing test, I am punting with #420, so the rest of ITK 5.4 RC 2 is not delayed further.

@jhlegarreta jhlegarreta merged commit 1b2e558 into InsightSoftwareConsortium:master Oct 30, 2023
13 checks passed
@thewtex thewtex deleted the itk-5.4rc02 branch November 3, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso approved these changes

@jhlegarreta jhlegarreta jhlegarreta approved these changes

Assignees
No one assigned
Labels
area:Filtering Issues affecting the Filtering module type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewtex @jhlegarreta @tbirdso