Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list pagination and proofs conflict #3

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Fix list pagination and proofs conflict #3

merged 3 commits into from
Jun 17, 2024

Conversation

Baptouuuu
Copy link
Member

Problem

The 4.1.1 release a fix to paginate the listing of paths. However it fails in some scenarii due to the characters contained in the continuation token.

Solution

Use the built-in PHP function to build the query string with the RFC3986 format.

Note

This PR also changes the bucket used to run the filesystem properties due to the fact that the other proofs can generate a directory and a file with the same name inside the bucket. This scenario is not supported by the properties.

This specific scenario has been generated in the bucket currently used to run the proofs, and the properties fail.

2 new buckets have been created to separate the avoid behaviours conflict between proofs and properties.

@Baptouuuu Baptouuuu added the bug Something isn't working label Jun 17, 2024
@Baptouuuu Baptouuuu self-assigned this Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.03%. Comparing base (c894b91) to head (4acf02a).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/Bucket/OverHttp.php 94.11% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop       #3      +/-   ##
=============================================
- Coverage      96.04%   96.03%   -0.02%     
  Complexity        49       49              
=============================================
  Files              9        9              
  Lines            607      605       -2     
=============================================
- Hits             583      581       -2     
  Misses            24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baptouuuu Baptouuuu merged commit b9e612f into develop Jun 17, 2024
7 of 9 checks passed
@Baptouuuu Baptouuuu deleted the fix-tests branch June 17, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant