-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messaging and enhance documentation in eip712_cosmos.go #240
base: dev
Are you sure you want to change the base?
Conversation
This PR improves error handling and enhances documentation in the eip712_cosmos.go file to provide clearer messages and more detailed explanations. Signed-off-by: Hwangjae Lee <[email protected]>
WalkthroughThe pull request introduces modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@aarmoa Hey, I’ve rebased to the dev branch and created the PR. Could you review it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #240 +/- ##
=======================================
Coverage 21.85% 21.85%
=======================================
Files 29 29
Lines 4378 4378
=======================================
Hits 957 957
Misses 3363 3363
Partials 58 58 ☔ View full report in Codecov by Sentry. |
This PR improves error handling and enhances documentation in the eip712_cosmos.go file to provide clearer messages and more detailed explanations.
##Changes:
err = errors.Wrapf(err, "failed to unpack Any in msg struct at field %s", fieldName)
Summary by CodeRabbit
Bug Fixes
Documentation
sanitizeTypedef
function to clarify its purpose and compatibility with EIP-712 signing requirements.