-
Notifications
You must be signed in to change notification settings - Fork 30
add twt2 #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add twt2 #352
Conversation
WalkthroughAdds TWT2 token to the public metadata and mainnet token registry. Updates symbolMeta with TWT2 fields and appends a corresponding mainnetTokens entry. Reorders the HPNJ block within mainnetTokens without changing its data. No method signatures or APIs changed; no testnet/devnet modifications. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/data/tokens/tokenFactory.ts (1)
567-570
: Avoid incidental reordering of HPNJ unless intentionalRepositioning HPNJ in mainnetTokens creates churn and raises merge‑conflict risk. If there’s no functional reason, please keep HPNJ at its previous location and only append TWT2.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/images/tokens/twt2.png
is excluded by!**/*.png
📒 Files selected for processing (2)
src/data/tokens/symbolMeta.ts
(1 hunks)src/data/tokens/tokenFactory.ts
(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/data/tokens/tokenFactory.ts (1)
src/data/tokens/symbolMeta.ts (1)
symbolMeta
(3-2378)
🔇 Additional comments (2)
src/data/tokens/symbolMeta.ts (1)
2364-2370
: TWT2 metadata LGTM — confirm display name and logoFields are complete and typed. Please confirm the user‑facing name “TEST RWA TOKEN” is intended for mainnet and that twt2.png follows your asset guidelines (size/format).
src/data/tokens/tokenFactory.ts (1)
564-566
: Verify TWT2 creator maps to on‑chain factory; assets presentsymbolMeta.TWT2 exists (src/data/tokens/symbolMeta.ts:2364); tokenFactory sets creator 'inj13we6l25kpzws8nlw0rnd30zejgcgq078fn4fag' (src/data/tokens/tokenFactory.ts:564–565); logo found at src/images/tokens/twt2.png — verify the creator address is the on‑chain TWT2 factory denom.
Add static token TWT2 (factory), include logo and metadata.
Summary by CodeRabbit
New Features
Chores