-
Notifications
You must be signed in to change notification settings - Fork 30
Update denoms.ts #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update denoms.ts #337
Conversation
Fixing $bINJ factory denom
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Added $SYN denom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/data/tokens/denoms.ts (1)
16-16
: Adding SYN expands scope beyond the PR intent—please confirm it’s intended and vettedThe PR description mentions fixing $bINJ only. Introducing a new verified denom (SYN) typically requires separate curation. If this was intentional and meets your “verified” criteria, consider updating the PR title/description; otherwise, move it to a separate PR to keep scope focused.
If you decide to keep this PR scoped strictly to $bINJ, apply this diff to drop the SYN line:
- 'factory/inj1a6xdezq7a94qwamec6n6cnup02nvewvjtz6h6e/SYN',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/data/tokens/denoms.ts
(1 hunks)
🔇 Additional comments (1)
src/data/tokens/denoms.ts (1)
15-15
: bINJ factory denom correction looks goodThe format follows the expected
factory/<inj address>/<subdenom>
pattern and the casing matches prior conventions. No issues spotted with this replacement.
Fixing $bINJ denom and adding $SYN denom
Summary by CodeRabbit
New Features
Chores