Skip to content

Conversation

mattnyy84
Copy link

@mattnyy84 mattnyy84 commented Aug 19, 2025

Fixing $bINJ denom and adding $SYN denom

Summary by CodeRabbit

  • New Features

    • Added recognition for three additional verified token denoms, enabling balances, prices, and transfers for bINJ, SYN, and DRUGS from new sources.
  • Chores

    • Removed a deprecated bINJ denom from the verified list to reduce clutter and prevent mismatches.
    • All other verified tokens remain unchanged.

Fixing $bINJ factory denom
@mattnyy84 mattnyy84 marked this pull request as draft August 19, 2025 16:46
Copy link

coderabbitai bot commented Aug 19, 2025

Walkthrough

Updated verifiedTokenFactoryDenoms: removed one existing denom and added three new denom entries; no API or signature changes.

Changes

Cohort / File(s) Summary of Changes
Token factory denom registry
src/data/tokens/denoms.ts
In verifiedTokenFactoryDenoms: removed inj10q36ygr0pkz7ezajcnjd2f0tat5n737yg6g6d5/bINJ; added inj1dxp690rd86xltejgfq2fa7f2nxtgmm5cer3hvu/bINJ, inj1a6xdezq7a94qwamec6n6cnup02nvewvjtz6h6e/SYN, and inj178zy7myyxewek7ka7v9hru8ycpvfnen6xeps89/DRUGS. Remaining entries unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibble code beneath the moon,
One token left, three hop in soon.
Addresses tidy, list in tune,
A carrot click, a soft codetroon.
Hooray—new denoms in my dune! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title correctly indicates that the changes occur in the denoms.ts file, which aligns with the updates made to the verifiedTokenFactoryDenoms entries, though it is somewhat generic and does not specify the key fixes and additions being introduced.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef60da and 59fc5f6.

📒 Files selected for processing (1)
  • src/data/tokens/denoms.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/data/tokens/denoms.ts

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Added $SYN denom
@mattnyy84 mattnyy84 marked this pull request as ready for review August 19, 2025 16:52
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/data/tokens/denoms.ts (1)

16-16: Adding SYN expands scope beyond the PR intent—please confirm it’s intended and vetted

The PR description mentions fixing $bINJ only. Introducing a new verified denom (SYN) typically requires separate curation. If this was intentional and meets your “verified” criteria, consider updating the PR title/description; otherwise, move it to a separate PR to keep scope focused.

If you decide to keep this PR scoped strictly to $bINJ, apply this diff to drop the SYN line:

-  'factory/inj1a6xdezq7a94qwamec6n6cnup02nvewvjtz6h6e/SYN',
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 23d29ed and 9ef60da.

📒 Files selected for processing (1)
  • src/data/tokens/denoms.ts (1 hunks)
🔇 Additional comments (1)
src/data/tokens/denoms.ts (1)

15-15: bINJ factory denom correction looks good

The format follows the expected factory/<inj address>/<subdenom> pattern and the casing matches prior conventions. No issues spotted with this replacement.

@mattnyy84 mattnyy84 closed this Sep 28, 2025
@mattnyy84 mattnyy84 reopened this Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant