Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symbolMeta.ts #196

Closed
wants to merge 1 commit into from
Closed

Conversation

spectre-inj
Copy link

@spectre-inj spectre-inj commented Dec 26, 2024

Adding new token Spectre

Summary by CodeRabbit

  • New Features
    • Added a new token entry for "SPC" with details including name, symbol, and logo.
    • Expanded the collection of token metadata.

Adding new token Spectre
Copy link

coderabbitai bot commented Dec 26, 2024

Walkthrough

The pull request introduces a new token metadata entry for "SPC" (Spectre) in the symbolMeta record. This addition expands the existing collection of token metadata by including specific details about the Spectre token, such as its decimal places, symbol, name, and logo file, without modifying any existing entries.

Changes

File Change Summary
ts-scripts/data/symbolMeta.ts Added new token metadata entry for SPC (Spectre) with properties:
- decimals: 6
- symbol: 'SPC'
- name: 'Spectre'
- logo: 'spc.svg'
- coinGeckoId: ''

Poem

🐰 A new token hops into view,
SPC joins the metadata crew!
Six decimals, Spectre's bright light,
In symbol records, a rabbit's delight! 🌟
Another entry, clean and neat,
Our token collection now complete! 🪙

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e188836 and 1987dc2.

📒 Files selected for processing (1)
  • ts-scripts/data/symbolMeta.ts (1 hunks)
🔇 Additional comments (1)
ts-scripts/data/symbolMeta.ts (1)

2114-2119: Confirm decimals and fill in CoinGecko ID if available.

Adding the token definition for "Spectre" (SPC) appears consistent with the surrounding metadata structure. However, please verify:

  1. Decimals: Ensure that 6 decimal places align with the official specification for this token.
  2. CoinGecko ID: If you have a CoinGecko listing for Spectre, consider populating the coinGeckoId field to enable price tracking features.

Run the script below to confirm there are no conflicting references or duplications of "SPC" in the codebase:

✅ Verification successful

Let me verify the decimals by checking the token metadata in the JSON files.


Let me try a different approach to check the token metadata.


Decimals and token metadata are correctly configured

The verification shows that the SPC token configuration in symbolMeta.ts is consistent with other token definitions across the codebase:

  • The 6 decimal places is confirmed in multiple token metadata files (externalTokens.json, mainnet.json, and bankMetadata/mainnet.json)
  • The empty coinGeckoId is consistent with other token definitions, suggesting the token is not yet listed on CoinGecko
  • The token is properly referenced in various configurations with consistent metadata and the same factory address
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for references to 'SPC' across the repo to ensure no collisions or conflicts.
rg "SPC"

Length of output: 2114


Script:

#!/bin/bash
# Check token metadata in various JSON files for decimals information
cat tokens/externalTokens.json tokens/mainnet.json data/bankMetadata/mainnet.json | jq -c 'select(.symbol == "SPC" or .name == "SPC")'

Length of output: 347


Script:

#!/bin/bash
# Check token metadata in JSON files with proper array handling
cat tokens/externalTokens.json | jq '.[] | select(.symbol == "SPC")'
cat tokens/mainnet.json | jq '.[] | select(.symbol == "SPC")'
cat data/bankMetadata/mainnet.json | jq '.[] | select(.symbol == "SPC")'

Length of output: 1264


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ThomasRalee
Copy link
Collaborator

can we consolidate the 3 PRs into one? Also can you please share more on your project?

@ThomasRalee ThomasRalee closed this Jan 2, 2025
@spectre-inj
Copy link
Author

Hi, thanks for your response.

Appreciate if you could guide me the way to consolidate everything into one. To be honest, I am new to github - still learning my ways.

As for the project - Spectre aims to bridge the gap between meme and real world usecase. We intend to create an apparel marketplace where $SPC can be used for purchasing purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants